This repository was archived by the owner on Nov 27, 2018. It is now read-only.
Make case class serialization more robust #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correctly serialize case classes that appear after their companion object * Correctly serialize case classes that are not contained in a package
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains fixes and tests to address two issues with case class serialization in jacks.
First, case classes in the root package cannot be serialized. This is because their scalap ClassSymbol names are prefixed with "<empty>.", which prevents them from being seen as the correct class in the jacks Scala module.
Second, jacks fails to correctly serialize case classes with a user-defined companion object, if that companion object is defined before the case class in the .scala file that contains them (companion objects have to be in the same file as the class to which they are a companion). This is because jacks simply finds the first scalap ClassSymbol from the file whose name matches the class name from the JavaType being serialized without checking whether that ClassSymbol is for the companion object.