Add WebDriver BiDi network logging with stable request IDs #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliandescottes
force-pushed
the
jdescottes-updates-bidi-fetch-pr
branch
from
7594c7e to
97daba0
Compare
juliandescottes
commented
Jan 7, 2026
| <a for=request>response tainting</a> is "<code>cors</code>". | ||
| <a for=request>mode</a> is "<code>cors</code>", | ||
| <a for=request>response tainting</a> is "<code>cors</code>", and | ||
| <a for=request>WebDriver id</a> is <var>request</var>'s <a for=request>WebDriver id</a>. |
Author
There was a problem hiding this comment.
Here I am not sure how to exactly specify that the new request should reuse the WebDriver id from the original request?
juliandescottes
force-pushed
the
jdescottes-updates-bidi-fetch-pr
branch
from
ba23447 to
59a91b0
Compare
Author
|
@annevk hi! this PR is meant to take over #1540 which you initially reviewed. Could you take a look and let me know if this addresses the concerns you initially raised. Normally we clarified the expectations from WebDriver BiDi regarding the lifecycle of the request object in w3c/webdriver-bidi#722 |
juliandescottes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the feedback on the existing PR #1540 as well as what was discussed in w3c/webdriver-bidi#722
This introduces the concept of a stable webdriver id for requests, which is consistent across redirects, authentication attempts and CORS preflight.
This also triggers steps from the webdriver bidi specification to emit network events and trigger data collection mecanisms.
Preview | Diff