Fixing debug-print for parameter "-p" #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change in behavior: - Lines 91, 181-184: Previously running "/home/user/logrotten -d -p /home/user/payload /home/user/.logs_backup/moodle_access" would yield a debug output of logfile: /home/user/.logs_backup/moodle_access [...] p: moodle_access where clearly "p" should display "payload". Lines 182, 183 are necessary, because otherwise a relative path to payload (by calling "./logrotten -d -p payload ./.logs_backup/moodle_access") would just yield "ayload" (without the "p"). I'd assume, the same issue could arise for some of the other parameters, if their path does not contain a "/" (the parameter "index" is set to "j+1" unconditionally). Cosmetic change: - Line 222: Modified the debug-print to display "payloadfile" instead of "p", as every other parameter is displayed by its long name.
Author
|
I just realized, that the comparison "if(strcmp(event->name,p) == 0)" later on breaks after this change. "event->name" equals "moodle_access" (name of the moved file) in my previous example, so the previously attached commit does not quite work. Nonetheless, the debug-print is kind of wrong for the parameter "p". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change in behavior:
logfile: /home/user/.logs_backup/moodle_access
[...]
p: moodle_access
where clearly "p" should display "payload". Lines 182, 183 are necessary, because otherwise a relative path to payload (by calling "./logrotten -d -p payload ./.logs_backup/moodle_access") would just yield "ayload" (without the "p"). I'd assume, the same issue could arise for some of the other parameters, if their path does not contain a "/" (the parameter "index" is set to "j+1" unconditionally).
Cosmetic change: