Fixed segfault when input file has not been found#5
Open
kurthuwig wants to merge 1 commit intowhpthomas:masterfrom
Open
Fixed segfault when input file has not been found#5kurthuwig wants to merge 1 commit intowhpthomas:masterfrom
kurthuwig wants to merge 1 commit intowhpthomas:masterfrom
Conversation
file_in is initialized with stdin. When opening it, a failure is indicated by the NULL value assigned to file_in. The application then tries to close the NULL file descriptor as it is not equal to stdin which gives a segmentation fault. This patch adds a check if the file descriptor is NULL and does not try to close it if this is the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file_in is initialized with stdin. When opening it, a failure is
indicated by the NULL value assigned to file_in. The application
then tries to close the NULL file descriptor as it is not equal to
stdin which gives a segmentation fault.
This patch adds a check if the file descriptor is NULL and does not
try to close it if this is the case.