Add initialization check for signing #410
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the initialization is not complete when trying to sign in, the response from the identity-provider will be "lost" because no `Notifier` is registered with the @openid/appauth code. This will lead to an infinite wait for the result of the login. That is quite time-consuming to debug. Therefore, an error should make things a lot easier for the programmer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the initialization is not complete when trying to sign in, the response from the identity-provider will be "lost" because no
Notifieris registered with the @openid/appauth code.This will lead to an infinite wait for the result of the login. That is quite time-consuming to debug. Therefore, an error should make things a lot easier for the programmer.
Maybe you can think of a more elegant solution. My point is just that there should be some mechanism to tell the developer that the service was used before being initialized...