Skip to content

Add initialization check for signing #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flgubler-ergon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add initialization check for signing #410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
354d2ab
Add initialization check for signing
flgubler-ergon Jan 28, 2025
f13a1ec
Fixed tests: apparently _initComplete does not emit quickly enough
flgubler-ergon Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/auth-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export class AuthService implements IAuthService {
private _authSubject: AuthSubject = new AuthSubject();
private _actionHistory: ActionHistoryObserver = new ActionHistoryObserver();
private _session: SessionObserver = new SessionObserver();
private _notifier: AuthorizationNotifier | undefined = undefined;

private _authSubjectV2 = new BehaviorSubject<IAuthAction>(AuthActionBuilder.Init());
private _tokenSubject = new BehaviorSubject<TokenResponse>(undefined);
Expand Down Expand Up @@ -191,6 +192,7 @@ export class AuthService implements IAuthService {
let notifier = new AuthorizationNotifier();
this.requestHandler.setAuthorizationNotifier(notifier);
notifier.setAuthorizationListener((request, response, error) => this.onAuthorizationNotification(request, response, error));
this._notifier = notifier;
}

protected onAuthorizationNotification(
Expand Down Expand Up @@ -342,6 +344,10 @@ export class AuthService implements IAuthService {
}

public async signIn(authExtras?: StringMap, state?: string) {
if (!this._notifier) {
throw new Error('Trying to sign in before AuthService is initialized!');
}

await this.performAuthorizationRequest(authExtras, state).catch((response) => {
this.notifyActionListers(AuthActionBuilder.SignInFailed(response));
});
Expand Down