[Core] Fix padding in BffResourceHeader #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Not a fan of decimal numbers when working with file formats, which is why I was using hexadecimal to begin with. But that's not something I'm going to choose to care about today. |
Collaborator
Author
I just saw other #[brw(align_after = x)] use decimal so I changed it for consistency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BffResourceHeader data size was being calculated incorrectly based on the padding calculation, this resulted in the stored size of the header data differing from the actual size, since the correct padding was being inserted by binrw. The issue manifested itself in cases that the header size wasn't exactly 16, for instance in Kalisto BigFiles.