Fix Python 3.14 compatibility: RuntimeError in BaseSettings iteration #1123
+22
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.14 enforces stricter rules around dictionary mutation during iteration. The BaseSettings class in minisettings.py was modifying cls.__dict__ via setattr() while iterating over it, causing a RuntimeError. Fixed by creating a snapshot of dictionary items before iteration in both __init_subclass__ and __init__ methods using list(cls.__dict__.items()). Fixes the import error: RuntimeError: dictionary changed size during iteration
Contributor
|
Thanks! |
Contributor
Author
|
Thanks for merging! Could you tag a new release? Maybe this already solves our problems. |
Contributor
|
I just released 1.55, which includes this fix. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.14 enforces stricter rules around dictionary mutation during iteration. The BaseSettings class in minisettings.py was modifying cls.dict via setattr() while iterating over it, causing a RuntimeError.
Fixed by creating a snapshot of dictionary items before iteration in both init_subclass and init methods using list(cls.dict.items()).
Fixes the import error:
RuntimeError: dictionary changed size during iteration
Closes #1107. Cherrypick from #1108.