chore: move confirmationDialog and Menu out of lab #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 27, 2024
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
iisakkirotko
force-pushed
the
12-23-feat_deprecate_use_thread
branch
from
f16af91 to
6bfa775
Compare
iisakkirotko
force-pushed
the
12-27-chore_move_confirmationdialog_and_menu_out_of_lab
branch
2 times, most recently
from
ee9172f to
46d3a8c
Compare
Contributor
maartenbreddels
left a comment
maartenbreddels
left a comment
There was a problem hiding this comment.
Same here, looks good! The only thing is the redirect for the docs.
iisakkirotko
force-pushed
the
12-23-feat_deprecate_use_thread
branch
from
6bfa775 to
f776b7c
Compare
iisakkirotko
force-pushed
the
12-27-chore_move_confirmationdialog_and_menu_out_of_lab
branch
from
46d3a8c to
78bc284
Compare
iisakkirotko
force-pushed
the
12-23-feat_deprecate_use_thread
branch
from
f776b7c to
d77b641
Compare
iisakkirotko
force-pushed
the
12-27-chore_move_confirmationdialog_and_menu_out_of_lab
branch
from
78bc284 to
3e0dac8
Compare
iisakkirotko
force-pushed
the
12-23-feat_deprecate_use_thread
branch
from
d77b641 to
6582fbf
Compare
iisakkirotko
force-pushed
the
12-27-chore_move_confirmationdialog_and_menu_out_of_lab
branch
from
3e0dac8 to
e9c0e89
Compare
iisakkirotko
changed the base branch from
12-23-feat_deprecate_use_thread
to
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
iisakkirotko
merged commit 7f91665
into
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
pre-commitprior to committing my changes (see development setup docs).Description of changes