fix!: use Mario's vuetify #977
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
from
e925b44 to
70e86a3
Compare
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
from
70e86a3 to
31a27a8
Compare
iisakkirotko
force-pushed
the
01-20-fix_use_mario_s_vuetify
branch
2 times, most recently
from
c76eff8 to
b9e7395
Compare
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
2 times, most recently
from
a97b75b to
1d29010
Compare
iisakkirotko
force-pushed
the
01-20-fix_use_mario_s_vuetify
branch
from
b9e7395 to
50b5119
Compare
Collaborator
Author
|
Requires widgetti/ipyvuetify#327, and for ipyvuetify's version to be bumped once the PR is released. I'll look a bit more into whether backwards compatibility could be relatively simply achieved tomorrow. |
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
from
0cef192 to
2bd9071
Compare
Fixes #588.
iisakkirotko
force-pushed
the
01-20-fix_use_mario_s_vuetify
branch
from
50b5119 to
a4ab501
Compare
Collaborator
Author
|
Fixed in widgetti/ipyvuetify#327, and mariobuikhuizen/vuetify@d47b630 instead. See #588 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
pre-commitprior to committing my changes (see development setup docs).Description of changes
Previously we didn't use the same version of Vuetify as ipyvuetify does, which could result in discrepancies, for isntance with CSS.
Fixes #588.