Solving the issue "Template matching regex features only matches prefix"

[Sahethi]

Heyy, I tried to solve this issue referring https://phabricator.wikimedia.org/T250522

I initially did want to pass a param to the template_names_matching() method but I believe it would have demanded changes in the definition in revscoring and passing a delimiter would still require the same amount of work, hence I individually added $ to every regex which called template_names_matching().

[halfak]

Can you add some tests to demonstrate the problem this solves?

[Sahethi]

@halfak Okay I'll try doing that

[he7d3r]

Have you considered a regex in the format (?:foo|bar|baz)$, with a single $ after the parenthesis?

[Sahethi]

okay I'll try to check that

[Sahethi]

hey, are you indicating a case scenario where we would have a regex as
Citation[_ ]needed$|Cn$|Fact$|(?:foo|bar|baz)$$ causing a double $

I've tired to check if it works as below

[he7d3r]

Oh, not really. I was thinking in something like this:
(?:Citation[_ ]needed|Cn|Fact)$
See https://regex101.com/r/GinCwl/1.

[Sahethi]

Oh, not really. I was thinking in something like this: (?:Citation[_ ]needed|Cn|Fact)$ See https://regex101.com/r/GinCwl/1.

Oh that does seem much better, thank you.
I'll do that and run some tests

[Sahethi]

Can you add some tests to demonstrate the problem this solves?

Hey sorry about getting back late. But I have been trying to match a regex pattern with the template and for some reason even for the pattern which doesn't match, the test doesn't seem to fail.

I have changed the code in articlequality/feature_lists/ptwiki.py to the following (only cn_templates is modified)

and the test on cn_templates still doesn't fail (test_cn_templates from articlequality/tests/feature_lists/test_ptwiki.py)