WFSSL-120 Improve logging when Wildfly OpenSSL misconfigured#145
WFSSL-120 Improve logging when Wildfly OpenSSL misconfigured#145RanabirChakraborty wants to merge 1 commit intowildfly-security:mainfrom
Conversation
darranl
left a comment
darranl
left a comment
There was a problem hiding this comment.
Thank you for your PR.
FYI in additional to my comments we should look at getting these strings in the Messages.java class.
| instance = new SSLImpl(); | ||
| } catch (Throwable e) { | ||
| //Log the initial failure to provide a clear root cause. | ||
| logger.log(Level.WARNING, "Failed to load wfssl native library from system path. Will attempt to load from classpath.", e); |
There was a problem hiding this comment.
I don't think we should log at WARN, I think Debug would be sufficient - logging an exception at WARN would lead to very verbose output that users will not be able to turn off - especially as this is only informational and the fallback mechanism may still work.
There was a problem hiding this comment.
Thanks, Fixed accordingly
| Runtime.getRuntime().load(libPath); | ||
| instance = new SSLImpl(); | ||
| } catch (Throwable t) { | ||
| throw new RuntimeException("Failed to load wfssl native library from specified path: " + libPath, t); |
There was a problem hiding this comment.
If we are throwing this exception is there not a more appropriate type we can use?
There was a problem hiding this comment.
Thanks, Fixed accordingly
RanabirChakraborty
force-pushed
the
WFSSL-120
branch
from
69f00d8 to
c3304dc
Compare
darranl
left a comment
darranl
left a comment
There was a problem hiding this comment.
Sorry we are still missing one further change, the message that is thrown in the exception should be obtained from Messages.java
RanabirChakraborty
force-pushed
the
WFSSL-120
branch
from
c3304dc to
7e733ee
Compare
|
@darranl thanks, did the changes. Please review now. |
2 participants
Issue: https://issues.redhat.com/browse/WFSSL-120