Lockwood/ink ripple update #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Icons][iOS] Pointing to version of material icon font that includes more metadata in the xml. (flutter#66684) * apply engine cherrypicks * Page-subclasses to take children instead of builder (flutter#66694) * Update pub dependencies to support dart 2.10.0 * cherry-pick 76ad864 * Fix the inconsistency between the local state of the input and the engine state (flutter#65754) Co-authored-by: Will Larche <larche@google.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: xubaolin <xubaolin@oppo.com>
* [Docs] [Material] Fix Icons api docs (flutter#66508) * [Docs] [Icons] Updating dart doc styles to recognize more styles of icons. All the 4 icon styles we support have to be pulled from 4 individual web fonts when we show the html page for api docs. * Better documentation and that special awful case. * Couple more places to remove. * Add back the autovalidate class property (flutter#66267) * Add back autovalidate property * Add autovalidate property back (include tests) * Fix typos * One more test :) * [flutter_tools] prevent running analyze-size with split-debug-info (flutter#66983) Running a build command with split debug info and analyze size causes a crash in the snapshot analysis library. Disable the combination of these two flags. Fixes flutter#66962 * fix invocatiion of non-existent function after cherry pick * update engine revision Co-authored-by: Will Larche <larche@google.com> Co-authored-by: Pedro Massango <pedromassango.developer@gmail.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com>
…word, according to the dictionary)
…n AOSP API versions 28 and above # Conflicts: # packages/flutter/lib/src/material/ink_ripple.dart
…e accidentally added during rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If you're changing visual properties, consider including before/after screenshots (and runnable code snippets to reproduce them).
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.