Feature/lambda #405

Daniel-Hoerauf · 2017-07-20T17:16:49Z

PR for issue # .

Ready for a PR?

I have updated the CHANGELOG with an entry including a description, a link to my profile, and a link to the issue ticket. This change is filed under an Enhancement or Bug Fix, is shown under the relevant release tag name, and is included in my PR branch.

Implementation Notes:

Migrated wombats-lambda and created a script to manage updating the Lambda functions.

Also includes the shell of the wombats standard library to work with Lambda and running locally, but it is not yet ported to all languages or documented.

Breaking changes:

dehli · 2017-07-24T17:16:38Z

src/wombats/lib/wombat_lib.clj

+
+(defn add-to-state
+  "Update the global saved state with the given element and position"
+  [matrix elem]


Probably would be cleaner to destructure in the args list so you don't need the let block.

(defn add-to-state [matrix {:keys [x y] :as elem}] (assoc matrix y (assoc (nth matrix y) x elem))

dehli · 2017-07-24T17:20:53Z

src/wombats/lib/wombat_lib.clj

+  If no self coordinates are provided, use distance from {:x 3 :y 3}"
+  ([dir {x_tar :x y_tar :y} arena-half {x_self :x y_self :y}]
+    (case dir
+          "n" (and (not (= y_tar y_self)) (>= arena-half (mod (- y_self y_tar) (* arena-half 2)))) 


(not= would probably be better

dehli · 2017-07-24T17:27:00Z

src/wombats/lib/wombat_lib.clj

+
+(defn can-shoot-barrier?
+  "Returns true if there is a barrier within shooting range"
+  ([dir arena arena-size shot-range self]


Isn't shooting range constant? If so it might be good to have this as a constant defined up top and use it down here.

dehli · 2017-07-24T17:29:46Z

src/wombats/lib/wombat_lib.clj

+  "Return true if you can move forward without a collision or poison"
+  [arena {x :x y :y}]
+  (not (in? (get-in (nth (nth arena y) x) [:contents :type])
+            ["zakano" "wombat" "wood-barrier" "steel-barrier" "poison"])))


Might be good for these strings to be constants up that can be used in a user's own functions / used here. Maybe something like zakano-key, etc.

dehli · 2017-07-24T17:30:47Z

src/wombats/lib/wombat_lib.clj

+  "Constructs an initial global state populated by fog"
+  [global-size]
+  (add-locs (into [] (map (fn [_] 
+     (into [] (map (fn [_] {:type "fog"}) (range global-size)))) (range global-size)))))


I think it would make sense to have this also as a constant up on top ("fog")

dehli · 2017-07-24T17:32:55Z

src/wombats/lib/wombat_lib.clj

+  [arena]
+  (reduce
+    #(conj %1
+      (reduce


I think map is a better method for this (and the following line). Thoughts?

I agree that using reduce isn't the clearest method here, but how would I be able to do this using map? I'm adding the location data to each tile in the arena so I need to know the position of the element relative to the beginning of the array. I was able to accomplish this by tracking the state in reduce's accumulator, but I couldn't see how I would be able to use map

Could you maybe use something like: map-indexed?

Yup, that'd work great. I just didn't know that was an available function. Thanks!

dehli

Some suggestions. Still need to review some more. Looks good though!

dehli · 2017-07-31T20:39:27Z

CHANGELOG.md

 [/oconn]: https://github.com/oconn
 [/erochest]: https://github.com/erochest
 [/elibosley]: http://github.com/elibosley
+[/daniel-hoerauf]: http://github.com/Daniel-Hoerauf


I would make this https for consistency.

dehli · 2017-07-31T20:41:27Z

lambda/javascript/index.js

@@ -0,0 +1,34 @@
+// Import the standard library and add elper functions to the same namespace


dehli · 2017-07-31T20:51:51Z

src/wombats/lib/wombat_lib.clj

+
+(defn get-arena-size
+  "Fetches the size of one side of the arena from the state"
+  [state]


So I'm not entirely sure that I like this more but figured I'd show some additional options. Feel free to use whichever you like the best.

(defn get-arena-size [{[width height] :global-dimensions}] {:width width :height height})

dehli · 2017-07-31T21:01:01Z

src/wombats/lib/wombat_lib.clj

+        size  (get-arena-size state)]
+    (if (nil? saved)
+      (build-initial-global-state size)
+      saved )))


extra space here

dehli · 2017-07-31T21:02:25Z

src/wombats/lib/wombat_lib.clj

+      2  :about-face
+      3  :right)))
+
+(defn can-shoot


I would make this end with a ? since it returns a boolean.

dehli · 2017-07-31T21:22:13Z

src/wombats/lib/wombat_lib.js

+                  y: local_state['global-coords'][1]
+    };
+
+    for (i = 0; i < local_tiles.length; i++) {


If you have to use a for loop, you should declare the variable.

for (let i = 0; i < ...

dehli · 2017-07-31T21:24:00Z

src/wombats/lib/wombat_lib.js

+  };
+
+  this.get_global_state = function(state, path) {
+    var temp = state;


What are you trying to do with temp here?

dehli · 2017-07-31T21:24:30Z

src/wombats/lib/wombat_lib.js

+        break;
+      case 'w':
+        return (target.x != wombat.x) && (x_half >= mod(wombat.x - target.x, (x_half * 2)));
+        break;


break isn't needed since you already have returned.

dehli · 2017-07-31T21:24:56Z

src/wombats/lib/wombat_lib.js

+        break;
+      case 'e':
+        return wom.y == tile.y && (shot_range >= mod(tile.x - wom.x, arena_size.width));
+        break;


break not needed.

dehli · 2017-07-31T21:25:37Z

src/wombats/lib/wombat_lib.js

+        return wom.x == tile.x && (shot_range >= mod(tile.y - wom.y, arena_size.height));
+        break;
+      case 'w':
+        return wom.x == tile.x && (shot_range >= mod(wom.y - tile.y, arena_size.width));


Daniel-Hoerauf added 6 commits July 19, 2017 11:19

Initial script to upload to Lambda

2c84d77

Lambda function name as an argument

00e0780

Updated README

73e5b13

Moved wombats lib to be tracked by git

92154e6

Added wombats lib for users running locally

3fd7c21

Updated CHANGELOG

2458963

Daniel-Hoerauf added the enhancement label Jul 20, 2017

elibosley requested a review from dehli July 20, 2017 17:17

dehli reviewed Jul 24, 2017

View reviewed changes

Daniel-Hoerauf added 4 commits July 25, 2017 11:20

Added Python support for standard library

05cd43c

Update Clojure library

6248fbd

Working Javascript library

74bef27

Support for rectangular arenas

37b99e7

dehli suggested changes Jul 31, 2017

View reviewed changes

Daniel-Hoerauf added 5 commits August 7, 2017 13:52

Some refactoring and beginning of documentation

5d80d30

Added README for python lib

57e2000

Added helper command to build complete response

ed42c9e

Added README for Javascript

c97bb42

Readme for Clojure

bf97c22

		@@ -0,0 +1,34 @@
		// Import the standard library and add elper functions to the same namespace

Feature/lambda #405

Are you sure you want to change the base?

Feature/lambda #405

Uh oh!

Conversation

Daniel-Hoerauf commented Jul 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR for issue # .

Ready for a PR?

Implementation Notes:

Breaking changes:

Uh oh!

dehli Jul 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dehli Jul 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dehli Jul 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dehli left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Daniel-Hoerauf commented Jul 20, 2017 •

edited

Loading

dehli Jul 24, 2017 •

edited

Loading

dehli Jul 24, 2017 •

edited

Loading

dehli Jul 25, 2017 •

edited

Loading

dehli left a comment •

edited

Loading