-
Notifications
You must be signed in to change notification settings - Fork 0
Docs/WPB-22269 add architecture overview #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
spoonman01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapt to alpha-numerical ordering after my PR is merged.
Decide where the core-concepts should be in the order and add a relevant category.json for the name.
I like adding the mermaid but as we talked we need to make it more clear. It's hard for me to suggest how.
One idea is to not have both EventsRouter and EventListener. Maybe just keeping the router is enough of an abstraction.
Also I would remove the connection between DevInterface -- domain objects --> Crypto. While correct it is ambiguous and the developer should not really care.
Ultimately, nitpicking a bit, I would flip the grapth vertically. For me it makes way more sense to have the "Wire Backend" on the top, SDK in the middle and "Developer Application" at the bottom
Adapt to alpha-numerical ordering
The icons from Wire iconography available on brand portal were converted into iconifyJSON format. https://wire.com/en/brand
This connection only matters when listening is initiated via `startListening()` method, but later no direct interaction happens.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
No clear way of understanding how SDK interacts with App and Backend, as well as no explanation of how different inner components communicate.
Solutions
Write architecture section with diagram.
Testing
How to Test
Run
npm ciandnpm start. Navigate to http://localhost:3000/core-concepts/architecure and see the content.Notes
This PR contains 2 to-dos to add links to
WireApplicationManagerreference and theShowcasesections once added.References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.