Wirepas Interoperability #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GwendalRaoul
left a comment
GwendalRaoul
left a comment
There was a problem hiding this comment.
Looks good to me.
As per our process, we will integrate the change in our internal repo and it will be visible on GitHub in next release.
| param = bytes(param, 'utf-8') | ||
| elif type(param) is int: | ||
| param.to_bytes((param.bit_length() + 7) // 8, byteorder='big') | ||
| param = param.to_bytes(max(1, (param.bit_length() + 7) // 8), byteorder='big') |
Contributor
There was a problem hiding this comment.
Good catch for the max in case param is 0 !
Author
|
Added a commit to patch a security bug. The IV was being left as all zeros previously. This initialises the IV appropriately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for interoperability via extended UID and standardised parameters
provisioning_method_eenum in provisioning library.to_bytesin the genConfigHex.py now converts integers to bytes