Skip to content

Conversation

@ran-dall
Copy link
Contributor

@ran-dall ran-dall commented Jul 15, 2022

This adds the configuration for VSCode Devcontainer and Codespaces.

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2022

🦋 Changeset detected

Latest commit: 5aaf4a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ran-dall
Copy link
Contributor Author

@natemoo-re Before this is ready, I think I want to get rid of nvm in favor of volta that you're already using.

@ran-dall ran-dall changed the title Add devcontainer configuration [🚧 WIP] Add devcontainer configuration Aug 1, 2022
@ran-dall
Copy link
Contributor Author

ran-dall commented Sep 28, 2022

@natemoo-re Restarting the work on this PR. So I replaced nvm with volta, but you still need to run volta install node && npm install --global pnpm to get everything set up. Maybe after volta-cli/volta#1273, things will get nicer, but till then, I think this is as good as it's going to get.

Otherwise, it can be merged as-is, and I'll update it later when that PR is merged.

@ran-dall ran-dall changed the title [🚧 WIP] Add devcontainer configuration Add devcontainer configuration Sep 28, 2022
@ran-dall ran-dall marked this pull request as ready for review September 28, 2022 00:46
@ran-dall
Copy link
Contributor Author

ran-dall commented Sep 28, 2022

@natemoo-re Actually, I fixed it. Now it will automatically set up node and pnpm@7.0.1 with volta automatically. 🎉

So now it's 💯 ready for primetime.

Signed-off-by: Randall <ran.dall@icloud.com>
Signed-off-by: Randall <ran.dall@icloud.com>
Signed-off-by: Randall <ran.dall@icloud.com>
Signed-off-by: Randall <ran.dall@icloud.com>
Signed-off-by: Randall <ran.dall@icloud.com>
Signed-off-by: Randall <ran.dall@icloud.com>
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice work!

@natemoo-re natemoo-re merged commit c27a7b5 into withastro:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants