Add stdout/stderr separation to ExecResult#81
Open
sarvanithin wants to merge 2 commits intowithmartian:mainfrom
Open
Add stdout/stderr separation to ExecResult#81sarvanithin wants to merge 2 commits intowithmartian:mainfrom
sarvanithin wants to merge 2 commits intowithmartian:mainfrom
Conversation
- Add RequestConverter[RequestType] Protocol for bidirectional conversion - Implement ChatCompletionConverter, ResponsesConverter, and MessagesConverter - Update LLMRequest methods to delegate to converters for better modularity - All existing tests pass (55/55), fully backward compatible - No changes required to calling code (chat_completions_compatible.py, etc.) Addresses issue withmartian#65: Improves abstraction and extensibility of LLMRequest conversion logic while maintaining 100% backward compatibility.
- Add stdout and stderr fields to ExecResult dataclass - Keep output property for backward compatibility (returns stdout + stderr) - Update DaytonaContainer and DockerContainer implementations - Update MockContainer and all test mocks - All tests pass (21/21), fully backward compatible Resolves container execution output TODO in containers.py:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds separate stdout and stderr fields to ExecResult for better debugging and error handling. Maintains backward compatibility via output property. All tests pass. Resolves TODO in containers.py line 11.