Conversation
tikank
reviewed
Dec 7, 2019
| if pip_version: | ||
| if pip_version >= (10, 0, 0): | ||
| if pip_version >= (19, 3, 1): | ||
| from pip._internal.main import main as pip_main |
Contributor
There was a problem hiding this comment.
Just a thought, that as pip user guide suggests to use pip program and the pip program is defined in entry points in setup.py, would getting that entry point to be a version independent way to find main function. Could something like this work:
Suggested change
| from pip._internal.main import main as pip_main | |
| pip_main = pkg_resources.load_entry_point('pip', 'console_scripts', 'pip') |
|
fwiw, I've tested this PR on openSUSE Tumbleweed, and it fixed my builds. Created #100 for a longer-term solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94
import main function from pip._internal.main for pip 19.3.1