SHA-3: harden against glitch attack #9722
Merged
+144
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
sha3-harden
branch
from
22450f8 to
71cc8ce
Compare
Contributor
Author
|
retest this please generic: node not responding |
SparkiDev
force-pushed
the
sha3-harden
branch
2 times, most recently
from
bb0258f to
0f6c5cc
Compare
Contributor
Author
|
retest this please nodes went away |
JacobBarthelmeh
requested changes
Jan 30, 2026
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Code changes look good but WC_SHA3_HARDEN should be added to the faultharden configure flag.
SparkiDev
force-pushed
the
sha3-harden
branch
from
335117d to
7259ee4
Compare
Check loop counts to ensure glitching didn't change number of times loop was performed.
SparkiDev
force-pushed
the
sha3-harden
branch
from
7259ee4 to
5924524
Compare
Contributor
Author
|
retest this please Jenkins node went down |
JacobBarthelmeh
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check loop counts to ensure glitching didn't change number of times loop was performed.
Fixes zd#21103
Testing
Standard SHA-3 testing
Checklist