Skip to content

Extend AIA interface#323

Merged
cconlon merged 1 commit intowolfSSL:masterfrom
padelsbach:aia-updates
Feb 5, 2026
Merged

Extend AIA interface#323
cconlon merged 1 commit intowolfSSL:masterfrom
padelsbach:aia-updates

Conversation

@padelsbach
Copy link
Contributor

Add ability to retrieve the Auth Info Access fields from a given cert as either OCSP or CA URL.

Requires wolfSSL/wolfssl#9728

@padelsbach padelsbach marked this pull request as ready for review February 3, 2026 19:42
@padelsbach padelsbach requested a review from cconlon February 3, 2026 19:43
@padelsbach padelsbach assigned cconlon and unassigned padelsbach Feb 3, 2026
@cconlon cconlon requested a review from Copilot February 3, 2026 22:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Java WolfSSLCertificate AIA interface to expose OCSP and CA Issuer URIs from certificates and to detect when the internal AIA URI list overflows, including tests and example certificates to validate the behavior.

Changes:

  • Added native and Java-level APIs on WolfSSLCertificate to retrieve OCSP responder URIs, CA Issuer URIs, and an AIA-overflow indicator, wired to the new wolfSSL C APIs (gated on version/feature macros).
  • Extended WolfSSLCertificateTest with AIA-focused tests, including multi-URI and overflow scenarios, and added helper logic for array membership checks.
  • Introduced example AIA certificates (multi-aia-cert.pem and overflow-aia-cert.pem) under examples/certs/aia/ to drive and document the new AIA behavior.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/test/com/wolfssl/test/WolfSSLCertificateTest.java Adds AIA tests (test_getAiaMulti, test_getAiaOverflow) and new cert path constants to validate OCSP/CA Issuer URI extraction and overflow reporting.
src/java/com/wolfssl/WolfSSLCertificate.java Introduces native bindings and synchronized Java wrappers for getOcspUris(), getCaIssuerUris(), and getAiaOverflow() with appropriate Javadoc and logging.
native/com_wolfssl_WolfSSLCertificate.h Declares new JNI entry points for the AIA-related X509 accessors consistent with the Java native method signatures.
native/com_wolfssl_WolfSSLCertificate.c Implements JNI glue for the new AIA APIs, including a shared helper to convert WOLF_STACK_OF(WOLFSSL_STRING) into String[], handling resource cleanup and feature gating by compile-time macros.
examples/certs/aia/multi-aia-cert.pem Example certificate with multiple OCSP and CA Issuer AIA URIs used by test_getAiaMulti.
examples/certs/aia/overflow-aia-cert.pem Example certificate with an AIA extension large enough to trigger the overflow condition, used by test_getAiaOverflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@cconlon cconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I'll hold off merge until wolfSSL/wolfssl#9728 gets in.

@cconlon cconlon merged commit 96f1fdb into wolfSSL:master Feb 5, 2026
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants