WA-NEW-008: Update PasswordReset error-copying for Rails 7 errors API#632
Open
kitcommerce wants to merge 1 commit intonextfrom
Open
WA-NEW-008: Update PasswordReset error-copying for Rails 7 errors API#632kitcommerce wants to merge 1 commit intonextfrom
kitcommerce wants to merge 1 commit intonextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
User::PasswordReset#completeto iterate errors using the Rails 7ActiveModel::Errorobject API (error.attribute,error.message) while maintaining backward compatibility with older Rails versions that yield[attribute, message]pairs.Closes #625
Client impact
None expected. Internal error-handling change. No public API changes.
Verify