Conversation
… broadcast channel during signal handling if no current runtime
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version to 0.2.17 and refactors several core modules to use the new HttpBody enum in place of heap‐allocated BoxBody. Key changes include:
- Updating middleware, HTTP message types, and gRPC response logic to rely on the HttpBody abstraction.
- Adding new configuration parameters (e.g. pipeline_flush, writev, max_concurrent_streams) and modifying default behaviors in server configuration.
- Enhancing IO stream handling with vectorized writes and rebind support on Linux, as well as minor adjustments in Ruby interface methods.
Reviewed Changes
Copilot reviewed 158 out of 158 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/itsi_server/src/server/middleware_stack/middlewares/auth_basic.rs | Replaces BoxBody with HttpBody for the unauthorized response. |
| crates/itsi_server/src/server/lifecycle_event.rs | Adds PartialEq derive for LifecycleEvent. |
| crates/itsi_server/src/server/io_stream.rs | Adjusts address conversion and introduces vectored write implementations. |
| crates/itsi_server/src/server/http_message_types.rs | Refactors body types and transitions from BoxBody to HttpBody throughout. |
| crates/itsi_server/src/server/binds/listener.rs | Introduces rebind_listener to improve listener behavior on Linux. |
| crates/itsi_server/src/ruby_types/itsi_server_config.rs | Adds new server parameters and updates default behavior for pin_worker_cores. |
| crates/itsi_server/src/ruby_types/file_watcher.rs | Updates base directory resolution and increases debounce duration. |
| crates/itsi_server/src/ruby_types/itsi_http_response.rs | Major refactor replacing BoxBody with HttpBody and updating response handling. |
| crates/itsi_server/src/ruby_types/itsi_http_request.rs | Adjusts response channel handling and header methods. |
| Various gRPC and body proxy modules | Updates consistent with the new HttpBody and response stream design. |
| Cargo.toml, CHANGELOG.md, .gitmodules | Version bump and dependency updates. |
Comments suppressed due to low confidence (2)
crates/itsi_server/src/ruby_types/itsi_server_config.rs:197
- The default value for 'pin_worker_cores' has been changed from true to false. Please confirm that this change is intentional as it may affect how worker CPU affinity is managed.
let pin_worker_cores: bool = rb_param_hash.fetch::<_, Option<bool>>("pin_worker_cores")?.unwrap_or(false);
crates/itsi_server/src/ruby_types/itsi_server/file_watcher.rs:35
- In extract_and_canonicalize_base_dir, the logic now returns the canonicalized current directory for non-wildcard patterns instead of attempting to discern between files and directories. Please verify this behavior matches the expected use case.
let base = PathBuf::from(".");
Deploying itsi with
|
| Latest commit: |
7e1e6cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://33513a1e.itsi.pages.dev |
| Branch Preview URL: | https://rc-0-2-17.itsi.pages.dev |
508ab3b to
ebd0f19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.