Skip to content

Rc/0.2.17#9

Merged
wouterken merged 6 commits intomainfrom
rc/0.2.17
Jun 1, 2025
Merged

Rc/0.2.17#9
wouterken merged 6 commits intomainfrom
rc/0.2.17

Conversation

@wouterken
Copy link
Owner

No description provided.

@wouterken wouterken requested a review from Copilot May 31, 2025 03:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the version to 0.2.17 and refactors several core modules to use the new HttpBody enum in place of heap‐allocated BoxBody. Key changes include:

  • Updating middleware, HTTP message types, and gRPC response logic to rely on the HttpBody abstraction.
  • Adding new configuration parameters (e.g. pipeline_flush, writev, max_concurrent_streams) and modifying default behaviors in server configuration.
  • Enhancing IO stream handling with vectorized writes and rebind support on Linux, as well as minor adjustments in Ruby interface methods.

Reviewed Changes

Copilot reviewed 158 out of 158 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/itsi_server/src/server/middleware_stack/middlewares/auth_basic.rs Replaces BoxBody with HttpBody for the unauthorized response.
crates/itsi_server/src/server/lifecycle_event.rs Adds PartialEq derive for LifecycleEvent.
crates/itsi_server/src/server/io_stream.rs Adjusts address conversion and introduces vectored write implementations.
crates/itsi_server/src/server/http_message_types.rs Refactors body types and transitions from BoxBody to HttpBody throughout.
crates/itsi_server/src/server/binds/listener.rs Introduces rebind_listener to improve listener behavior on Linux.
crates/itsi_server/src/ruby_types/itsi_server_config.rs Adds new server parameters and updates default behavior for pin_worker_cores.
crates/itsi_server/src/ruby_types/file_watcher.rs Updates base directory resolution and increases debounce duration.
crates/itsi_server/src/ruby_types/itsi_http_response.rs Major refactor replacing BoxBody with HttpBody and updating response handling.
crates/itsi_server/src/ruby_types/itsi_http_request.rs Adjusts response channel handling and header methods.
Various gRPC and body proxy modules Updates consistent with the new HttpBody and response stream design.
Cargo.toml, CHANGELOG.md, .gitmodules Version bump and dependency updates.
Comments suppressed due to low confidence (2)

crates/itsi_server/src/ruby_types/itsi_server_config.rs:197

  • The default value for 'pin_worker_cores' has been changed from true to false. Please confirm that this change is intentional as it may affect how worker CPU affinity is managed.
let pin_worker_cores: bool = rb_param_hash.fetch::<_, Option<bool>>("pin_worker_cores")?.unwrap_or(false);

crates/itsi_server/src/ruby_types/itsi_server/file_watcher.rs:35

  • In extract_and_canonicalize_base_dir, the logic now returns the canonicalized current directory for non-wildcard patterns instead of attempting to discern between files and directories. Please verify this behavior matches the expected use case.
let base = PathBuf::from(".");

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 31, 2025

Deploying itsi with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e1e6cd
Status: ✅  Deploy successful!
Preview URL: https://33513a1e.itsi.pages.dev
Branch Preview URL: https://rc-0-2-17.itsi.pages.dev

View logs

@wouterken wouterken force-pushed the rc/0.2.17 branch 12 times, most recently from 508ab3b to ebd0f19 Compare June 1, 2025 05:06
@wouterken wouterken merged commit 8aa6ec7 into main Jun 1, 2025
3 checks passed
@wouterken wouterken deleted the rc/0.2.17 branch June 1, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments