Open
Conversation
Whenever log files were loaded, the old ones weren't being unloaded
| file.flush(); | ||
| } | ||
|
|
||
| delete tempDir; |
Contributor
There was a problem hiding this comment.
Yes. new without delete. memory leak...
robinking623
approved these changes
Feb 22, 2026
robinking623
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that whenever log files were loaded, the old ones weren't being unloaded. For example, when we switch profiles in the logs tab, the "load logs" process runs again, but the memory was appearing to grow every time. I added a list to store the references for the log entries created during the load, so that, on the next load, we can delete them before creating new ones.
I'm not sure if the deletes for sf and tempDir that I added are really necessary, but it didn't crash haha