Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| """Command-line interface for vdbbench.""" | ||
|
|
||
| import argparse | ||
| from typing import List, Optional | ||
|
|
||
| from . import compact_and_watch, list_collections, load_vdb, simple_bench |
There was a problem hiding this comment.
The CLI now imports every subcommand module eagerly (compact_and_watch, list_collections, etc.) during module import. vdbbench.list_collections imports tabulate at module level and will crash with ModuleNotFoundError if that optional dependency is missing, which now prevents unrelated commands like vdbbench load or vdbbench compact from running at all. Previously each script only required its own dependencies. Consider deferring the import of each subcommand until the user actually invokes it so that optional dependencies remain isolated.
Useful? React with 👍 / 👎.
1 participant
Summary
vdbbenchCLI with subcommands for benchmarking, loading, compaction monitoring, and listing collectionsTesting
https://chatgpt.com/codex/tasks/task_b_68e52c7f8ee48321a781a4bc5392ba82