Test cases for prototype (and some linter cleaning)#157
Open
admosity wants to merge 5 commits intox-tag:masterfrom
Open
Test cases for prototype (and some linter cleaning)#157admosity wants to merge 5 commits intox-tag:masterfrom
admosity wants to merge 5 commits intox-tag:masterfrom
Conversation
- added test case for propagating content when using prototype
Author
|
Added some test cases for mixins, but can't seem to replicate the issue I'm having. I think in my case the lifecycle triggers from the mixins aren't firing. Will add some test cases with lifecycle hooks. |
components using prototype
Author
Member
|
I have retooled the mixin section of the test spec to cover your cases (I think). If there are any outstanding, I will gladly accept a new commit with any I may have missed :) |
Member
|
I believe I incorporated the meat of this into the code - if not, let me know and I will address the remaining. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added some test cases for using prototype.
contentwhen using prototype.Commenting out
passes the test.
