rayon: Use parallel iterators within shards #360
+13
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#116 added rayon support, but parallelized only across shards, since std's hashmap does not support parallelization. Since dashmap exclusively uses hashbrown since #259, we can use hashbrown's rayon support for parallel iterators inside the hashmap.
This sounds like an obvious win in theory, but I'm not very familiar with rayon and I'm not sure if there could be some overhead from scheduling. Perhaps @cuviper could say if this is what he had in mind when writing the "implementation note" comment?