Skip to content

Conversation

@klardotsh
Copy link

This can be seen even in a repl - stdlib subprocess.run('clang') will pass through the error about no input files, this library will swallow it because it sets stderr/stdout to subprocess.PIPE by default. This PR fixes that.

Same drill as my other two PRs, not 100% clean. Includes #4. Can rebase.

@klardotsh
Copy link
Author

Will fix tests some day that's not today - interesting that this suddenly fails when the result I'm seeing on screen is what one would expect.

@klardotsh
Copy link
Author

Closing this to clear out my Pull Requests view on GitHub. Looks like Textio's fork is still public, though I haven't worked there in years so can't speak to its maintenance story, whether it's still in use, etc. I'll leave any future upstreaming efforts to them if they so desire.

@klardotsh klardotsh closed this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants