CA-411988 Fix TypeError in LVHDoHBASR.load() with direct parent call #787
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace super() with direct parent class call to fix "TypeError: super(type, obj): obj must be an instance or subtype of type" when SR.from_uuid() dynamically loads the module. This aligns load() with all other methods in the class (create, attach, scan, probe, detach, delete) which already use direct parent calls. Signed-off-by: Lunfan Zhang[Lunfan.Zhang] <Lunfan.Zhang@cloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases,
sr_health_checkfails with:This occurs when
SR.from_uuid()dynamically loads the module, potentially creating separateLVHDoHBASRclass objects in memory. Python's super() validates class identity and fails when the class reference differs from the instance's class.Replace
super(LVHDoHBASR, self).load(sr_uuid)withLVHDSR.LVHDSR.load(self, sr_uuid)This direct parent call bypasses class identity validation and aligns with all other methods(create, detach etc.) in this class.