Display brief comments in preview window#199
Display brief comments in preview window#199gribozavr wants to merge 6 commits intoxavierd:masterfrom
Conversation
This requires updating libclang.py to the latest version.
This is done by serializing the whole completion result data structure in a vim-compatible way instead of relying on python and vim representation being somewhat compatible.
Two approaches: * optimize string concatenation; * do a special conversion only if it is needed.
The issue is that we were calling clang_getCompletionBriefComment unconditionally. New we check if this function is available before calling it.
|
Hi Tobias, I have pushed a few commits that should address your comments. |
|
Will the brief comments from clang binary also be supported in clang_complete (for g:clang_use_library = 0)? I've found that there is a new -code-completion-brief-comments parameter in the source code of the clang frontend executable (but not yet available in release 3.1 for mingw). |
|
@awlosnie: I would personally prefer to remove support for the clang binary completely. What is the reason you can not use libclang? @gribozavr: I just created a pull request (#213) that updates clang_complete to the latest version of cindex.py. This request also adds support for brief comments. Would you mind rebasing your patchset on top of this pull request. I would like to get this feature into clang_complete. |
|
@TobiG: Thank you for your answer. I had a problem to configure it right in windows in gvim, so my solution was based on the executable version of clang. After your post I tested it ones again and now it seams to work with the libclang.dll (I just had to rename clang.dll to libclang.dll). |
|
On 11/19/2012 10:40 AM, awlosnie wrote:
@awlosnie: Great! Tobi |
|
+1 for this feature |
4 participants
This change uses the new Clang documentation support to extract brief comments. This requires updating libclang.py to the latest version.
Partially fixes issue #174.