You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using pyeval() in vim to avoid all the str() call in python. That way, no conversion is done. However, this requires an up to date vim, as noted in #270.
I think it would be unfortunate to require everybody to compile their own vim versions. This adds a lot of overhead,
for a very limited benefit. My vim version supports threads very well and works flawless with the current clang_complete. The only missing featue is pyeval. I just tried this patch with a manual installation. It gives
a speedup from 0.007s to 0.004s. Given that I have an overall completion time of 0.138783, this does not make a big difference. From my point it seems we can get along very well without using pyeval. However, if you think the
speedup is still wanted, we can probably support both the old and the new vim at the same time. Your change request has only four changed lines. Making them conditional on the availability of pyeval should not be too involved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From 0.012s to 0.004s.
I'm using pyeval() in vim to avoid all the str() call in python. That way, no conversion is done. However, this requires an up to date vim, as noted in #270.