Added ability to specify paths for options files#347
Open
muff1nman wants to merge 3 commits intoxavierd:masterfrom
Open
Added ability to specify paths for options files#347muff1nman wants to merge 3 commits intoxavierd:masterfrom
muff1nman wants to merge 3 commits intoxavierd:masterfrom
Conversation
Author
|
Any update on this? Thanks! |
For both compile_commands.json and .clang_complete, there were added some global variables to allow the user to customize where to find these files.
Owner
|
I would prefer if you only add one configuration that specify the search path for both .clang_complete and compile_commands.json. Can you also rebase and squash all of those commits, and test with the autochdir option set? Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to be able to use out of tree builds with cmake, and not have to worry about copying over the compile_commands.json file. In this branch, you are now able to specify a filename to search for. In my case, I can specify:
which will properly find all the header files based on my cmake configurations.
Now the the code isn't exactly perfect. As you can see above, I kept how the clang_auto_user_options worked for backwards compatabilty and decided to add two new global variables for specifying the search path. The other variable is for the .clang_complete search path (g:clang_complete_search_path). Im not sure if changing the path for .clang_complete is as helpful but I figured we should keep the logic the same.