Skip to content
This repository was archived by the owner on Aug 30, 2022. It is now read-only.

Conversation

@Robert-Steiner
Copy link
Member

Cherry-pick trust anchor trait + implementation into the state machine from #636

  • applied review comments

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #682 (52aed60) into master (0e0a93e) will increase coverage by 0.04%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   62.95%   63.00%   +0.04%     
==========================================
  Files          97       98       +1     
  Lines        4430     4446      +16     
==========================================
+ Hits         2789     2801      +12     
- Misses       1641     1645       +4     
Impacted Files Coverage Δ
rust/xaynet-server/src/state_machine/mod.rs 75.00% <ø> (ø)
...ver/src/storage/coordinator_storage/redis/impls.rs 72.72% <0.00%> (ø)
...erver/src/storage/coordinator_storage/redis/mod.rs 71.20% <ø> (ø)
rust/xaynet-server/src/storage/traits.rs 66.66% <ø> (ø)
rust/xaynet-server/src/storage/store.rs 80.00% <72.72%> (-4.10%) ⬇️
...t/xaynet-server/src/state_machine/phases/unmask.rs 58.33% <75.00%> (+0.12%) ⬆️
...st/xaynet-server/src/state_machine/phases/error.rs 75.00% <80.00%> (ø)
rust/xaynet-server/src/settings/mod.rs 92.18% <100.00%> (+0.12%) ⬆️
...ust/xaynet-server/src/state_machine/initializer.rs 82.50% <100.00%> (ø)
...ust/xaynet-server/src/state_machine/phases/idle.rs 73.68% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0a93e...52aed60. Read the comment docs.

Copy link
Contributor

@janpetschexain janpetschexain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reduction of generic type parameters to be carried around is pretty nice 👍

@Robert-Steiner Robert-Steiner merged commit 5783e26 into master Jan 21, 2021
@Robert-Steiner Robert-Steiner deleted the trust_anchor_trait branch January 21, 2021 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants