Open
Conversation
Waqar-ukaea
added
the
GPRT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
GPRTRayTracer::occluded()method to behave in the same way it does inEmbreeRayTracer(). This PR has been developed from theHEADof #154. So it will need to wait until that PR is ready to be merged in first. I could refactor this in such a way that doesn't require #154 but I felt it was easier to do it this way.I've refactored
test_occludedto follow the same pattern used in other tests which are testing both embree and GPRT and the tests produce consistent results across the two test instantiations.