You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for your effort in contributing to the project!
I appreciate the improvements you've made, particularly the unification of indentation in LuaFile.cs. However, I have some concerns regarding other aspects of your pull request:
Some files, like Assets/UniLua/Class1.cs, appear to be unnecessary.
There are files included that I believe should not be under version control, such as those in the .vs folder and the Assets/UniLua/.vs/UniLua/FileContentIndex/ folder.
I'm not quite sure what the intentions are behind some of the changes.
Due to these issues, I am unable to accept the pull request at this time. Please revise your changes accordingly, and feel free to resubmit once these concerns are addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.