Skip to content

Conversation

@ydirson
Copy link
Contributor

@ydirson ydirson commented Jul 30, 2024

No description provided.

Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
@freddy77
Copy link
Contributor

Maybe would be worth stating the comparison is done case-insensitive.

Not a regression, I found a small exception due to code:

    def parseUIConfirmationPrompt(self):
        results = {}
        nodes = getElementsByTagName(self.top_node, ['ui-confirmation-prompt'])
        if len(nodes) > 0:
            results['ui-confirmation-prompt'] = bool(getText(nodes[0]))
        return results

The bool conversion will return true for any not empty string, even "false" or "0".

@GeraldEV
Copy link
Contributor

It would be good to address the issue @freddy77 raised to ensure that the docs are correct when this PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants