Increase code quality by getting rid of compiler warnings#54
Conversation
|
Thanks! Integrated them into AlexanderWillner@66f74d2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to increase the overall code quality by fixing the causes of current compiler warnings.
@A-A-G I noticed you also made these changes in your PlatformIO branch - but without a PR yet. This PR will make them generally available in trunk for further development.
Notes:
It is possible that some of the changes are already part of other open PRs. However these PRs are either stale or address the wrong target branch (master).
The contained commits
f151599and115acbfare already part of PR Add PlatformIO and Visual Studio Code specific files to .gitignore #53 and just contained again for sake of compatible dev environment while that PR is still pending.