Allow disabling previous and next page checks#131
Open
StijnKing wants to merge 1 commit intoxing:masterfrom
Open
Allow disabling previous and next page checks#131StijnKing wants to merge 1 commit intoxing:masterfrom
StijnKing wants to merge 1 commit intoxing:masterfrom
Conversation
The previous_page? and next_page? methods in certain cases require a count query in order to determine if the next/previous pages exists. These count queries can be expensive so an option to disable these checks are added. For backwards compatibility these checks are enabled by default. Co-authored-by: adamsosterics <sosterics.adam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When we use this gem it causes two count queries before the actual query happens. But because of performance reasons we want to avoid having these count queries. So I would like to propose this PR (or something similar).
Reason
The previous_page? and next_page? methods in certain cases require a count query in order to determine if the next/previous pages exists. These count queries can be expensive so an option to disable these checks are added.
For backwards compatibility these checks are enabled by default.