Remove total count comparison for next and previous page check#158
Open
bc-afeng wants to merge 1 commit intoxing:masterfrom
Open
Remove total count comparison for next and previous page check#158bc-afeng wants to merge 1 commit intoxing:masterfrom
bc-afeng wants to merge 1 commit intoxing:masterfrom
Conversation
Author
|
Hi, @nicolas-fricke any chance you could take a look at this PR? With the current implementation we are essentially mitigating any improvements provided by cursor pagination as we are having to query all items. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that even without providing
with_total: true, paginator was performing twoselect count(*)queries in order to determine the next and previous pages. This has also been highlighted as an issue in #132.To determine the existence of a next page we should be able to just rely on the existence of a cursor. This PR removes the total count check.
The logic here is that if a cursor has been provided, we must have come from a page that provided us a cursor. This should also significantly speed up deep queries.