Fix:GHA if conditional is not bash, so it can't accept regex. #361
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the GitHub Actions workflow where regex pattern matching was incorrectly attempted in a GitHub Actions conditional expression (which doesn't support regex). The fix consolidates two workflow steps into one and moves the regex validation into a bash script where it can be properly evaluated.
Key changes:
- Moved semantic version regex validation from GitHub Actions
ifconditional to bash script - Consolidated "Strip leading 'v'" and "Set release version" steps into a single step
- Introduced a
validoutput flag to control downstream notification step execution - Pinned
peter-evans/repository-dispatchaction to a specific commit SHA
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 2 2
=========================================
Hits 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| echo "After: $RELEASE" | ||
| echo "release=$RELEASE" >> $GITHUB_OUTPUT | ||
| - name: Set release version |
There was a problem hiding this comment.
why are we removing this step? this allows for the use of the release regardless of the format. if it fails later on it will be somewhere we are more likely to see it.
There was a problem hiding this comment.
Good question. It seemed like we always released using semver now, so this enforces that, and it seemed like an extra step that didn't do much.
No description provided.