Symfony 3.4 support: Fix service aliases and avoid errors on config compilation#13
Closed
akserikawa wants to merge 4 commits intoxmon:masterfrom
Closed
Symfony 3.4 support: Fix service aliases and avoid errors on config compilation#13akserikawa wants to merge 4 commits intoxmon:masterfrom
akserikawa wants to merge 4 commits intoxmon:masterfrom
Conversation
Author
|
Oh, noticed #9 right after submitting this PR. It'd be great to integrate that one and close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing the bundle on a Symfony 3.4 project, the following errors arise:
Errors on config compilation
(1/1) InvalidDefinitionException->cannotBeEmpty() is not applicable to NumericNodeDefinition.Errors due to service aliases not wrapped on single quotes
(2/2) InvalidArgumentExceptionThe file "/var/www/html/vendor/xmon/sonata-media-provider-video-bundle/Xmon/SonataMediaProviderVideoBundle/DependencyInjection/../Resources/config/providers.yml" does not contain valid YAML: The reserved indicator "@" cannot start a plain scalar; you need to quote the scalar at line 15 (near "- @sonata.media.filesystem.local").@xmon It would be great to add this changes and tag a new version so projects can use this package :)