Re-add support for g:lua_path
#33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idbrii
suggested changes
Mar 12, 2018
idbrii
left a comment
idbrii
left a comment
There was a problem hiding this comment.
Causes errors for users who don't set g:lua_path
autoload/xolox/lua.vim
Outdated
|
|
||
| let s:lua_path_cache = ['', []] | ||
| function! xolox#lua#getsearchpath(envvar, luavar) " {{{1 | ||
| if exists('s:lua_path_cache') && s:lua_path_cache[0] == g:lua_path |
There was a problem hiding this comment.
Unchecked use of g:lua_path here causes E121: Undefined variable: g:lua_path for me.
Is this exists check testing the wrong thing? s:lua_path_cache will always exist since it's defined above.
Contributor
Author
There was a problem hiding this comment.
testing the wrong thing?
Seems so, amended.
Commit 6d68f3d removed the functionality to define/override $LUA_PATH, but the documentation still mentions it. This also adds support for caching in xolox#lua#getsearchpath, which appears to be useful anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6d68f3d removed the functionality to define/override $LUA_PATH,
but the documentation still mentions it.
This also adds support for caching in xolox#lua#getsearchpath, which
appears to be useful anyway.
I could also imagine a way to support extending the path (prepending and/or appending to it).
My use case is the awesome window manager, which adjusts its path internally, and changes are not reflected in
$LUA_PATHor the lua interpreter.