Open
Conversation
The struct insn_t's .bytes member is an array of length MAX_INSN_LENGTH, which is #define'd to 15 in line 179 of injector.c. The initialization of total_range in line 320 (which is of type range_t, starring two members (.start and .end) of type insn_t, however, uses 16 bytes for the initialization of the .bytes arrays. Fix it by removing one element from the initializations.
mitchelhaan
approved these changes
Sep 15, 2017
GBuella
reviewed
Sep 15, 2017
| range_t total_range={ | ||
| .start={.bytes={0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00}, .len=0}, | ||
| .end={.bytes={0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff}, .len=0}, | ||
| .start={.bytes={0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00}, .len=0}, |
There was a problem hiding this comment.
Is there a reason for writing out all those zeros?
Why not simply:
.bytes = {0, }
19h
approved these changes
Jan 21, 2018
zolez
approved these changes
May 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
struct insn_ts.bytesmember is an array of lengthMAX_INSN_LENGTH, which is#define'd to15in line 179 ofinjector.c.The initialization of
total_rangein line 320 (which is of typerange_t, starring two members (.startand.end) of typeinsn_t,however, uses 16 bytes for the initialization of the
.bytesarrays.Fix it by removing one element from the initializations.
Fixes (parts of) #2, #3 and #5.