Skip to content
This repository was archived by the owner on Mar 7, 2023. It is now read-only.

Conversation

@tribock
Copy link
Member

@tribock tribock commented Feb 4, 2019

No description provided.

type JobStatus int

// JobStatus implementation as enum
const (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is aligned to the yabs/api, looks good

type RunnerStatus int

// RunnerStatus implementation as enum
const (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fforootd
and here the runner status

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did reduce the api side to the following

enum Status {
    UNKNOWN = 0;
    ACTIVE = 1;
    PAUSED = 2;
    ONLINE = 3;
    OFFLINE = 4;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this alignment with the gitlab-runner status conditions works for me so far 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants