Please consider this small change in the code #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that include ";" in the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Janne,
I have made a small modification in the script in the first split (line 62) in order to split the lines only by the semicolons that are at the end of line.
It happens that the Spanish Government provides some data with a semicolon in the descriptions and your script didn't work :(
I've tried the modification with your example data and seems to be OK.
May be you can test the modification with other files in order to check that the change doesn't break anything and then consider accepting the Request.
Thank you very much for the code and for making it public.
Bests regards,
Pedro-Juan