Spawn point logic changes #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spawn points are now generated using generate_waypoints() for random spawns junction spawns are now handled by get_waypoint_by_lane_id() next is being used for junction waypoints because of an issue with s=0 being confused for predecessor road/junction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spawn points are now generated using generate_waypoints() for random spawns
junction spawns are now handled by get_waypoint_by_lane_id()
next() is being used for junction waypoints because of an issue with s=0 being confused for predecessor road/junction. The module converts waypoint to transform, then for relative vehicle position the transform is used to get waypoint. This led to the waypoint being on the wrong road as the original waypoint was for s=0. Using next() removes the issue.
Where has this been tested?
Possible Drawbacks
There could be edge cases which have not been discovered yet.