Support nullable StructType fields via Optional wrapper #98
+241
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckySting
suggested changes
Dec 22, 2025
|
|
||
| def visit_optional(self, type_: types.Optional, **kw): | ||
| el = type_.element_type | ||
| if isinstance(el, type): |
Contributor
There was a problem hiding this comment.
suggestion: Let's use the helper function from the sqlaclhemy:
from sqlalchemy.sql.type_api import to_instance
The same below
Comment on lines
+164
to
+168
| for field, field_type in type_.fields_types.items(): | ||
| type_str = self.process(field_type, **kw) | ||
| text += f"{field}:{type_str}," | ||
| if text.endswith(","): | ||
| text = text[:-1] |
Contributor
There was a problem hiding this comment.
suggestion (non-blocking): Let's use join here, like
return f"Struct<{','.join(...)}>"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types.Optionalwrapper for nullable fields inStructType.StructType.from_table(table)helper method to generate StructType from sa.Table.StructTypebinding.test/test_core.py.