Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/test_suite.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,6 @@ class NumericTest(_NumericTest):
pass


@pytest.mark.skip("TODO: see issue #13")
class BinaryTest(_BinaryTest):
pass

Expand Down
3 changes: 3 additions & 0 deletions ydb_sqlalchemy/sqlalchemy/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ class YqlDialect(StrCompileDialect):
sa.types.DATETIME: types.YqlDateTime,
sa.types.TIMESTAMP: types.YqlTimestamp,
sa.types.DECIMAL: types.Decimal,
sa.types.BINARY: types.Binary,
sa.types.LargeBinary: types.Binary,
sa.types.BLOB: types.Binary,
}

connection_characteristics = util.immutabledict(
Expand Down
2 changes: 1 addition & 1 deletion ydb_sqlalchemy/sqlalchemy/compiler/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def get_ydb_type(
ydb_type = ydb.PrimitiveType.Timestamp
elif isinstance(type_, sa.Date):
ydb_type = ydb.PrimitiveType.Date
elif isinstance(type_, sa.BINARY):
elif isinstance(type_, (sa.BINARY, sa.LargeBinary, types.Binary)):
ydb_type = ydb.PrimitiveType.String
elif isinstance(type_, sa.Float):
ydb_type = ydb.PrimitiveType.Float
Expand Down
7 changes: 7 additions & 0 deletions ydb_sqlalchemy/sqlalchemy/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,10 @@ def __init__(self, func):

self.type = type_api.NULLTYPE
self.func = func


class Binary(types.LargeBinary):
__visit_name__ = "BINARY"

def bind_processor(self, dialect):
return None