Skip to content

Support export / import s3 topics configuration in YDBCP #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stanislav-shchetinin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support export / import s3 topics configuration in YDBCP #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions internal/connectors/client/connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func listDirectory(ctx context.Context, clientDb *ydb.Driver, initialPath string
}

result := make([]string, 0)
if dir.Entry.IsTable() {
if dir.Entry.IsTable() || dir.Entry.IsTopic() {
if !excluded(initialPath) {
xlog.Debug(ctx, "Included path", zap.String("path", initialPath))
result = append(result, initialPath)
Expand All @@ -164,7 +164,7 @@ func listDirectory(ctx context.Context, clientDb *ydb.Driver, initialPath string
}

result = append(result, list...)
} else if child.IsTable() {
} else if child.IsTable() || child.IsTopic() {
if !excluded(childPath) {
xlog.Debug(ctx, "Included path", zap.String("path", childPath))
result = append(result, childPath)
Expand Down Expand Up @@ -321,8 +321,11 @@ func prepareItemsForImport(dbName string, s3Client S3API, s3Settings types.Impor
},
func(p *s3.ListObjectsOutput, last bool) (shouldContinue bool) {
for _, object := range p.Contents {

// Check for table (scheme.pb) or topic (create_topic.pb)
key, found := strings.CutSuffix(*object.Key, "scheme.pb")
if !found {
key, found = strings.CutSuffix(*object.Key, "create_topic.pb")
}
if found {
shouldRestore := backupEverything || pathPrefixes[key]
if shouldRestore {
Expand Down