fix(contracts): subscriptions count in payment service addSubscriptions #2241
+10
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the addSubscriptions behavior to only add to the active subscriptions counter when the address was not already subscribed.
How to test
Start the anvil node and deploy the anvil contracts with:
To fetch the current value of the active subscriptions counter:
cast call 0x922D6956C99E12DFeB3224DEA977D0939758A1Fe "activeSubscriptionsAmount()(uint256)"To call the addSubscriptions method:
The array of addresses can be changed.
The thing to test is that the counter does not change when the addresses are already subscribed.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging